Add workflow for discount function settings

packages/app/src/cli/prompts/generate/extension.ts

@@ -73,7 +73,7 @@ export function buildChoices(extensionTemplates: ExtensionTemplate[], unavailabl
   return templateSpecChoices.sort(compareChoices)
 }
 
-const generateExtensionPrompts = async (
+export const generateExtensionPrompts = async (
   options: GenerateExtensionPromptOptions,
 ): Promise<GenerateExtensionPromptOutput> => {
   let extensionTemplates = options.extensionTemplates
@@ -109,7 +109,6 @@ const generateExtensionPrompts = async (
     // extensionChildren [identifiers]
     extensionChildren: extensionTemplate.relatedExtensions?.map((elem) => elem.name) ?? [],
   }
-  // TODO: here perhaps return a flag, that lets us know that there are possible next steps
 
   return {extensionTemplate, extensionContent}
 }

packages/app/src/cli/services/generate.ts

@@ -41,62 +41,32 @@ export interface GenerateOptions {
 async function generate(options: GenerateOptions) {
   const {app, developerPlatformClient, remoteApp, specifications, template} = options
 
-  // console.log('GENERATE', options)
-
   const availableSpecifications = specifications.map((spec) => spec.identifier)
   const extensionTemplates = await fetchExtensionTemplates(developerPlatformClient, remoteApp, availableSpecifications)
 
   const promptOptions = await buildPromptOptions(extensionTemplates, specifications, app, options)
   const promptAnswers = await generateExtensionPrompts(promptOptions)
 
-  // Add related extension children for product discounts
-  if (promptAnswers.extensionTemplate.identifier === 'product_discounts') {
-    const settingsTemplate = extensionTemplates.find((template) => template.identifier === 'discount_function_settings')
-    if (settingsTemplate) {
-      const mockSettingsPromptAnswers: GenerateExtensionPromptOutput = {
-        extensionTemplate: settingsTemplate,
-        extensionContent: {
-          name: `${promptAnswers.extensionContent.name}-settings`,
-          flavor: 'react',
-          relatedExtensions: [],
-        },
-      }
-
-      // Generate the settings extension
-      const settingsGenerateOptions = buildGenerateOptions(
-        mockSettingsPromptAnswers,
-        app,
-        options,
-        developerPlatformClient,
-      )
-      await generateExtensionTemplate(settingsGenerateOptions)
-    }
-  }
-
-  console.log('PROMPT ANSWERS', promptAnswers)
-  // Call module related to that child extension
   await saveAnalyticsMetadata(promptAnswers, template)
 
-  // We can add an extra generated extension here.
   const generateExtensionOptions = buildGenerateOptions(promptAnswers, app, options, developerPlatformClient)
   const generatedExtension = await generateExtensionTemplate(generateExtensionOptions)
 
   const workflow = workflowRegistry[generatedExtension.extensionTemplate.identifier]
   await workflow?.afterGenerate({
     generateOptions: options,
     extensionTemplateOptions: generateExtensionOptions,
+    extensionTemplates: extensionTemplates,
   })
-
   renderSuccessMessage(generatedExtension, app.packageManager)
 }
 
-async function buildPromptOptions(
+export async function buildPromptOptions(
   extensionTemplates: ExtensionTemplate[],
   specifications: ExtensionSpecification[],
   app: AppInterface,
   options: GenerateOptions,
 ): Promise<GenerateExtensionPromptOptions> {
-  // console.log('BUILDING PROMPT OPTIONS', arguments)
   const extensionTemplate = await handleTypeParameter(options.template, app, extensionTemplates, specifications)
   validateExtensionFlavor(extensionTemplate, options.flavor)
 
@@ -128,7 +98,6 @@ function checkLimits(
 }
 
 function limitReached(app: AppInterface, specifications: ExtensionSpecification[], template: ExtensionTemplate) {
-  // console.log('CHECKING LIMITS', specifications)
   const type = template.type
   const specification = specifications.find((spec) => spec.identifier === type || spec.externalIdentifier === type)
   const existingExtensions = app.extensionsForType({identifier: type, externalIdentifier: type})
@@ -145,7 +114,7 @@ async function saveAnalyticsMetadata(promptAnswers: GenerateExtensionPromptOutpu
   }))
 }
 
-function buildGenerateOptions(
+export function buildGenerateOptions(
   promptAnswers: GenerateExtensionPromptOutput,
   app: AppInterface,
   options: GenerateOptions,
@@ -160,7 +129,7 @@ function buildGenerateOptions(
   }
 }
 
-function renderSuccessMessage(extension: GeneratedExtension, packageManager: AppInterface['packageManager']) {
+export function renderSuccessMessage(extension: GeneratedExtension, packageManager: AppInterface['packageManager']) {
   const formattedSuccessfulMessage = formatSuccessfulRunMessage(
     extension.extensionTemplate,
     extension.directory,

packages/app/src/cli/services/generate/extension.ts

@@ -81,7 +81,6 @@ export async function generateExtensionTemplate(
   const extensionFlavor = options.extensionTemplate.supportedFlavors.find(
     (flavor) => flavor.value === extensionFlavorValue,
   )
-  // TODO For grouping we might want to setup directories/groups for extensions
   const directory = await ensureExtensionDirectoryExists({app: options.app, name: extensionName})
   const url = options.cloneUrl || options.extensionTemplate.url
   const uid = options.developerPlatformClient.supportsAtomicDeployments ? randomUUID() : undefined

packages/app/src/cli/services/generate/workflows/discount-details-function-settings-collection.ts

@@ -0,0 +1,43 @@
+import {renderConfirmationPrompt} from '@shopify/cli-kit/node/ui'
+import {Workflow} from './registry.js'
+import {generateExtensionTemplate} from '../extension.js'
+import {generateExtensionPrompts} from '../../../prompts/generate/extension.js'
+import {buildGenerateOptions, renderSuccessMessage, buildPromptOptions} from '../../generate.js'
+import {GenerateExtensionPromptOutput} from '../../../prompts/generate/extension.js'
+
+export const discountDetailsFunctionSettingsCollection: Workflow = {
+  afterGenerate: async (options) => {
+    console.log('OPTIONS', options)
+    const {app, developerPlatformClient, remoteApp, specifications, template} = options.generateOptions
+
+    const shouldCreateFunction = await renderConfirmationPrompt({
+      message: 'Would you like to create a function for this extension?',
+      defaultValue: true,
+    })
+
+    if (shouldCreateFunction) {
+      // create a function extension
+      const extensionTemplates = options.extensionTemplates.filter(
+        (template) =>
+          template.identifier === 'shipping_discounts' ||
+          template.identifier === 'product_discounts' ||
+          template.identifier === 'order_discounts' ||
+          template.identifier == 'discounts_allocator',
+      )
+      console.log('FUNCTION specs', specifications)
+      console.log('FUNCTION TEMPLATES', extensionTemplates)
+
+      const promptOptions = await buildPromptOptions(extensionTemplates, specifications, app, options.generateOptions)
+      const promptAnswers = await generateExtensionPrompts(promptOptions)
+
+      const generateExtensionOptions = buildGenerateOptions(
+        promptAnswers,
+        app,
+        options.generateOptions,
+        developerPlatformClient,
+      )
+      const generatedExtension = await generateExtensionTemplate(generateExtensionOptions)
+      renderSuccessMessage(generatedExtension, app.packageManager)
+    }
+  },
+}

packages/app/src/cli/services/generate/workflows/registry.ts

@@ -1,10 +1,13 @@
 import {editorExtensionCollection} from './editor-extension-collection.js'
 import {GenerateOptions} from '../../generate.js'
 import {GenerateExtensionTemplateOptions} from '../../generate/extension.js'
+import {discountDetailsFunctionSettingsCollection} from './discount-details-function-settings-collection.js'
+import {ExtensionTemplate} from '../../../models/app/template.js'
 
 interface AfterGenerateOptions {
   generateOptions: GenerateOptions
   extensionTemplateOptions: GenerateExtensionTemplateOptions
+  extensionTemplates: ExtensionTemplate[]
 }
 
 export interface Workflow {
@@ -17,4 +20,5 @@ interface WorkflowRegistry {
 
 export const workflowRegistry: WorkflowRegistry = {
   editor_extension_collection: editorExtensionCollection,
+  discount_details_function_settings: discountDetailsFunctionSettingsCollection,
 }