Default to using the latest patch version of shopify_function #5045
Conversation
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
| @@ -246,7 +246,7 @@ async function uiExtensionInit({ | |||
|
|
|||
| if (templateLanguage === 'javascript') { | |||
| await changeIndexFileExtension(directory, srcFileExtension) | |||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
There was a problem hiding this comment.
This was apparently some auto-linting, I assume I should leave it.
|
@andrewhassan @saulecabrera Any concerns with auto-accepting new patch releases by default here? |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1973 tests passing in 895 suites. Report generated by 🧪jest coverage report action from 3d8ce6a |
There was a problem hiding this comment.
I believe the exact version number was used prior to 1.0, in which it was harder to ensure compatibility guarantees between versions. Now that we've reached 1.0 I think this makes sense.
I'll leave the final approval to @andrewhassan in case he wants to share any feedback.
|
I think we also need to update the string here. Perhaps we can extract the version out to a constant? |
|
I've included this in my PR here |
I was going to update to use v1.0.3 but shouldn't we just encourage use of the latest patch?