Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UID instead of handle to identify extensions in app-watcher #5150

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 3, 2025

WHY are these changes introduced?

switch from using extension handles to UIDs as the primary identifier for extensions in the app watcher.

WHAT is this pull request doing?

  • Updates extension diffing to compare UIDs instead of handles
  • Modifies UUID generation to be deterministic based on the extension handle
  • Use UID in the whole app-watcher/dev-session flow.
  • Adds some code to detect folder movements.

How to test your changes?

  1. Create a new app with multiple extensions
  2. Start the dev server
  3. Try moving extension folders around (inside the extensions folder)
  4. Verify that extensions are properly tracked and rebuilt
  5. Test deleting extensions and confirm proper cleanup

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan marked this pull request as ready for review January 3, 2025 10:17
@isaacroldan isaacroldan requested a review from a team as a code owner January 3, 2025 10:17
Copy link
Contributor

github-actions bot commented Jan 3, 2025

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.24% (+0.02% 🔼)
8854/11768
🟡 Branches
70.51% (+0.04% 🔼)
4296/6093
🟡 Functions
75.15% (+0.01% 🔼)
2317/3083
🟡 Lines
75.79% (+0.03% 🔼)
8371/11045
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% 90.48% 98.61%

Test suite run success

1996 tests passing in 903 suites.

Report generated by 🧪jest coverage report action from 66b63f7

@isaacroldan isaacroldan force-pushed the 01-03-use_uid_instead_of_handle_to_identify_extensions_in_app-watcher branch from 10ab3ae to 66b63f7 Compare January 7, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant