Fix extension_directories wildcards to always be recursive #5160
+45
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success2000 tests passing in 903 suites. Report generated by 🧪jest coverage report action from b874496 |
dmerand
reviewed
Jan 7, 2025
| // If a path ends with a single asterisk, modify it to end with a double asterisk. | ||
| // This is to support the glob pattern used by chokidar and watch for changes in subfolders. | ||
| function fixSingleWildcards(value: string[] | undefined) { | ||
| return value?.map((dir) => dir.replace(/\*$/, '**')) |
There was a problem hiding this comment.
Wouldn't this regex also convert a double-asterisk to a triple-asterisk? I think you might want a captured non-asterisk, followed by an asterisk and then end-of-line, as your regex:
Suggested change
| return value?.map((dir) => dir.replace(/\*$/, '**')) | |
| return value?.map((dir) => dir.replace(/([^\*])\*$/, '$1**')) |
There was a problem hiding this comment.
Good catch, this will work for any kind of path type / or \
I'll add tests to it though :)
isaacroldan
force-pushed
the
01-07-fix_extension_directories_wildcards_to_always_be_recursive
branch
from
9d66cb8 to
b874496
Compare
dmerand
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To improve the handling of custom extension directory paths in app configuration by ensuring proper glob pattern support for watching changes in subfolders.
WHAT is this pull request doing?
Adds functionality to automatically convert single asterisk wildcards (
*) to double asterisks (**) in extension directory paths. This ensures proper recursive watching of subdirectories when using chokidar for file watching duringdev.How to test your changes?
custom_extensionsextension_directories = ['custom_extensions/*']devMeasuring impact
Checklist