Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement exponential backoff for polling; improve logging #5163

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

catlee
Copy link
Contributor

@catlee catlee commented Jan 7, 2025

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.22% (+0.01% 🔼)
8849/11764
🟡 Branches
70.48% (+0.03% 🔼)
4293/6091
🟡 Functions
75.15% (+0.06% 🔼)
2316/3082
🟡 Lines
75.77% (+0.02% 🔼)
8366/11041
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / dev.ts
77.78% (-0.22% 🔻)
65% (-0.22% 🔻)
81.25% (+3.47% 🔼)
74.36% (-0.64% 🔻)
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%
🔴
... / partners-client.ts
25.9% (-0.38% 🔻)
37.5% 17.86%
25.56% (-0.19% 🔻)

Test suite run success

1996 tests passing in 903 suites.

Report generated by 🧪jest coverage report action from 8259b83

@catlee
Copy link
Contributor Author

catlee commented Jan 7, 2025

/snapit

Copy link
Contributor

github-actions bot commented Jan 7, 2025

🫰✨ Thanks @catlee! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant