Add product configuration link extension template #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazirpascual
force-pushed
the
lazirpascual/add-product-config-link-extension
branch
from
bd8a121 to
69c9700
Compare
lazirpascual
commented
Nov 27, 2024
templates.json
Outdated
| "group": "Admin", | ||
| "supportLinks": [], | ||
| "url": "https://github.com/Shopify/extensions-templates", | ||
| "type": "product_configuration_link", |
There was a problem hiding this comment.
Not 100% sure what the type here should be.
definition of type from https://vault.shopify.io/page/Create-an-extension-template~cqQS.md:
type: identifier of the extension type that the template contains, it should be identical to the one defined in the Core specification
There was a problem hiding this comment.
The identifier for the new cli extension will be product_configuration_link_extension.
There was a problem hiding this comment.
product_configuration_link will continue to refer to the old dashboard-managed extension
lazirpascual
force-pushed
the
lazirpascual/add-product-config-link-extension
branch
from
9575774 to
dbca95e
Compare
hannakebedom
reviewed
Dec 3, 2024
hannakebedom
reviewed
Dec 3, 2024
hannakebedom
reviewed
Dec 3, 2024
hannakebedom
reviewed
Dec 3, 2024
lazirpascual
force-pushed
the
lazirpascual/add-product-config-link-extension
branch
from
ec66c7b to
b3e2842
Compare
hannakebedom
approved these changes
Dec 10, 2024
| type = "product_configuration_link_extension" | ||
| handle = "{{ handle }}" | ||
| {% if uid %}uid = "{{ uid }}"{% endif %} | ||
| pattern = "/bundles{?product_id,shop}&id={contract_id}" |
There was a problem hiding this comment.
Suggested change
| pattern = "/bundles{?product_id,shop}&id={contract_id}" | |
| pattern = "/bundles{?product_id,shop}" |
The pattern should actually be just this as contract_id isn't a query parameter for us, my bad for the previous suggestion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Closes https://github.com/Shopify/bundles-app/issues/2855
Solution
Followed steps in https://vault.shopify.io/page/Create-an-extension-template~cqQS.md
Checklist