Fix hydrogen upgrade command when using yarn as the package manager

[dsnvs]

WHY are these changes introduced?

hydrogen upgrade command currently uses installNodeModules() from the cli-kit to upgrade packages, this function uses install as the arg for the package manager, and when using yarn, the arg for adding new dependencies (or updating existing ones) is add.

WHAT is this pull request doing?

It updates the hydrogen upgrade command to instead use addNPMDependenciesIfNeeded() (also from cli-kit) which appears to be the most adequate solution for this command.

HOW to test your changes?

Upgrade hydrogen from an older version to a newer version using yarn (and other package managers to validate they also work as expected).

Checklist

• I've read the Contributing Guidelines
• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've added a changeset if this PR contains user-facing or noteworthy changes
• I've added tests to cover my changes
• I've added or updated the documentation

[dsnvs]

I have signed the CLA!

[wizardlyhel]

Mmm .. didn't realize that yarn didn't work for hydrogen upgrade. Thanks for the catch.

There are a couple problems that we identify with this approach:

1. addNPMDependenciesIfNeeded skips dependencies that are already included in package.json. That means it won't update the versions, as far as we understand.
2. It splits the installation in 3 steps: prod, dev, remix. That's going to be slower than doing it all at once.
3. It stops using buildUpgradeCommandArgs, which is the function we test in upgrade.test.ts. If the way we install deps change, we should update the tests accordingly to have the new path covered.
4. There are only check for remix dependencies for the prod dependencies but didn't check for the dev dependencies. Since this command modifies package.json in the end, the remix dev dependencies version should match those in dependencies list

Since the actual problem is in installNodeModules where it assumes the args is install, I think a simpler fix is actually in the cli-kit itself https://github.com/Shopify/cli/blob/main/packages/cli-kit/src/public/node/node-package-manager.ts#L202
In that function, we know what package manager is being used. It's simpler to make the change there.

[wizardlyhel]

^