Reenqueue the job after shutdown hooks have run #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardy31
reviewed
Nov 17, 2021
cardy31
reviewed
Nov 17, 2021
cardy31
reviewed
Nov 17, 2021
cardy31
reviewed
Nov 17, 2021
cardy31
reviewed
Nov 17, 2021
MatthewRBruce
force-pushed
the
mb-reenqueue-after-shutdown-hook
branch
from
d857f2f to
cbb0184
Compare
MatthewRBruce
commented
Nov 17, 2021
MatthewRBruce
force-pushed
the
mb-reenqueue-after-shutdown-hook
branch
3 times, most recently
from
57d1930 to
a38f62a
Compare
Mangara
approved these changes
Nov 17, 2021
We discovered a race condition where a job can be re-enqueued a new run executed before the previous runs' shutdown hooks have been completed. This change ensures the shutdown hooks have run before the job is re-enqueued. Add test update CHANGELOG
MatthewRBruce
force-pushed
the
mb-reenqueue-after-shutdown-hook
branch
from
3952929 to
0fe8cfe
Compare
|
We looked into something similar with #66. In addition to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a race condition where a job can be re-enqueued a new run executed before the previous runs' shutdown hooks have been completed. This change ensures the shutdown hooks have run before the job is re-enqueued.
Fixes: https://github.com/Shopify/job-platform/issues/534