Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Document argument passing semantics #362

Merged
merged 8 commits into from
Mar 28, 2023

Conversation

julik
Copy link
Contributor

@julik julik commented Mar 26, 2023

It is not really clear from the documentation how arguments to perform are supposed to propagate through the call stack, and if one needs to blind-explore it leads to some rather surprising results. Maybe documenting it could help?..

julik added 3 commits March 26, 2023 21:45
It is not really clear from the documentation how arguments to `perform` are supposed to propagate through the call stack, and if one needs to blind-explore it leads to some rather surprising results. Maybe documenting it could help?..
@julik
Copy link
Contributor Author

julik commented Mar 26, 2023

This will likely address #220 as well

Copy link
Contributor

@Mangara Mangara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much!

guides/argument-semantics.md Outdated Show resolved Hide resolved
Co-authored-by: Sander Verdonschot <[email protected]>
@Mangara Mangara merged commit c0dd4fe into Shopify:main Mar 28, 2023
@lavoiesl lavoiesl mentioned this pull request Aug 15, 2023
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems August 23, 2023 19:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants