Pass strict_variables and strict filters to render context #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you call
render
(orrender!
) withstrict_variables
orstrict_filters
set to true, when you render a partial using therender
tag those directives are ignored.It seems to me if you want to raise errors on invalid variables or filters, you'll want that to be the case in rendered partials too.
Solution
Pass
strict_variables
andstrict_filters
to a context'snew_isolated_subcontext