Add find
, find_index
, has
, and reject
filters to arrays
#1869
+382
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the RFC#1864 and introduces support for the
find
,find_index
,has
, andreject
filters into the Liquid Array API.The new filters support multi-level access to drops, so they can access properties like this:
For the sake of consistency, multi-level access has been introduced for all related filters in the Array API:
map
,sort
,sort_natural
,sum
,uniq
,where
, andcompact
.--
Special thanks to @andershagbard who started this work on #1573 and #1749. I'm including those commits as part of this PR; while the implementation approach is slightly different, important work happened there, and it's valuable to have that context in the Liquid commit history.
Also, thank you to everyone who contributed with thoughts and suggestions in the RFC.