Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing webhook topic definitions #241

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add missing webhook topic definitions #241

wants to merge 4 commits into from

Conversation

frankiejarrett
Copy link

@frankiejarrett frankiejarrett commented Jan 15, 2023 •
edited
Loading

WHY are these changes introduced?

As a best practice, apps should reference these constants rather than hardcoding topic strings in case they change in the future.

WHAT is this pull request doing?

Adds 48 missing webhook constants.

Full list: https://shopify.dev/api/admin-graphql/2023-01/enums/webhooksubscriptiontopic

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frankiejarrett