Add deletion and raw http endpoint urls for Webhooks #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I couldn't add a webhook, because it insists on making all HttpDelivery webhooks a path of Context::$HOST_NAME (which was myshop.myshopify.com), and I wanted a webhook on my server.
I also couldn't delete a webhook.
WHAT is this pull request doing?
Added a new enum to Webhooks::Registry::register
which doesn't try and get smart with the provided url
To allow deletion of webhooks with the maximum code re-use, I modified Webhooks::Registry::register to equate an empty
$path
with a request to delete the webhook.Type of change
Checklist
There's documentation?