Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rest cannot update model because identifier is removed from array #325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix rest cannot update model because identifier is removed from array #325

wants to merge 1 commit into from

Conversation

makoso
Copy link

@makoso makoso commented Feb 24, 2024 •
edited
Loading

WHAT is this pull request doing?

Fix rest cannot update model because primary id is removed from array when computing difference

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@makoso makoso force-pushed the fix/fix-rest-update-not-working branch from c6aab4c to 22d6688 Compare February 24, 2024 15:44
@shakaran
Copy link
Contributor

@makoso could you add a test covering this special case? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-needed Waiting for Response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makoso @shakaran @matteodepalo