Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always handle download link as internal #297

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Jan 8, 2025

Ensure seamless navigation from primary (slicer.org) to auxiliary (download.slicer.org) site.

Set link_class to handle links with the force-internal-link class, preventing auxiliary site links from opening in a new tab.

Modify footer-site-map.yml and hero buttons to support link_class.

Ensure seamless navigation from primary (`slicer.org`) to auxiliary (`download.slicer.org`) site.

Set `link_class` to handle links with the `force-internal-link` class,
preventing auxiliary site links from opening in a new tab.

Modify `footer-site-map.yml` and hero buttons to support `link_class`.
@slicerbot
Copy link

slicerbot commented Jan 8, 2025

download.slicer.org preview [branch: deploy_download_maintenance_preview]

⚠️ The download preview is a static website generated using mock data 1, is temporary and may be updated at anytime 2

Screenshot from https://deploy-download-maintenance-preview--slicer-org.netlify.app/download.html
Screenshot

Footnotes

  1. See front matter variable download_mock associated with https://raw.githubusercontent.com/Slicer/slicer.org/main/download.markdown

  2. Due to limitation of Netlify preventing us from having multiple deploy previews associated with a single pull request and the impossibility of using repository secret in a workflow associated with a pull-request originating from forks, the deploy-download-preview site is only updated for pull request originating from this repository and will be overriden after another pull request is pushed or updated.

@slicerbot
Copy link

slicerbot commented Jan 8, 2025

download.slicer.org preview [branch: deploy_download_preview]

⚠️ The download preview is a static website generated using mock data 1, is temporary and may be updated at anytime 2

Screenshot from https://deploy-download-preview--slicer-org.netlify.app/download_release_and_nightly.html Screenshot from https://deploy-download-preview--slicer-org.netlify.app/download_only_release.html Screenshot from https://deploy-download-preview--slicer-org.netlify.app/download_only_nightly.html
Screenshot Screenshot Screenshot
Screenshot from https://deploy-download-preview--slicer-org.netlify.app/download_release_and_nightly.html
Screenshot

Footnotes

  1. See front matter variable download_mock associated with https://raw.githubusercontent.com/Slicer/slicer.org/main/download.markdown

  2. Due to limitation of Netlify preventing us from having multiple deploy previews associated with a single pull request and the impossibility of using repository secret in a workflow associated with a pull-request originating from forks, the deploy-download-preview site is only updated for pull request originating from this repository and will be overriden after another pull request is pushed or updated.

@jcfr jcfr merged commit aa430b1 into main Jan 8, 2025
11 checks passed
@jcfr jcfr deleted the always-handle-download-site-as-internal branch January 8, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants