This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
shamilovtim,
diehuxx and
frankhinek
as code owners
September 21, 2024 16:56
KendallWeihe
commented
Sep 21, 2024
KendallWeihe
commented
Sep 21, 2024
bound/kt/src/test/kotlin/tbdex/sdk/vectors/TbdexTestVectorsProtocolTest.kt
Outdated
Show resolved
Hide resolved
Ready for review, but still need to implement some of the foreign fetch pieces |
nitro-neal
reviewed
Sep 27, 2024
#[wasm_bindgen] | ||
extern "C" { | ||
#[wasm_bindgen( | ||
typescript_type = "{ fetch: (url: string, options?: WasmFetchOptions) => WasmResponse }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where did we land on this? This is the way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed the way, but a couple items to touch up subsequently...
- There may be a slightly better way to define the
typescript_type
than inlining the attribute like this - @diehuxx and I have talked about a slight rework with the
http-std
crate inweb5-rs
which this currently utilizes - We need to make everything all the way down async ASAP, because right now I have a hacky workaround in typescript via worker threads
nitro-neal
reviewed
Sep 27, 2024
nitro-neal
reviewed
Sep 27, 2024
nitro-neal
reviewed
Sep 27, 2024
nitro-neal
reviewed
Sep 27, 2024
nitro-neal
reviewed
Sep 27, 2024
nitro-neal
reviewed
Sep 27, 2024
nitro-neal
approved these changes
Sep 27, 2024
KendallWeihe
force-pushed
the
kendall/bind-wasm-starter
branch
from
September 29, 2024 22:37
ff640fd
to
9e7925b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.