Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Add wasm foundations #122

Merged
merged 61 commits into from
Sep 30, 2024
Merged

Add wasm foundations #122

merged 61 commits into from
Sep 30, 2024

Conversation

KendallWeihe
Copy link
Contributor

@KendallWeihe KendallWeihe commented Sep 21, 2024

No description provided.

bound/kt/pom.xml Outdated Show resolved Hide resolved
@KendallWeihe KendallWeihe marked this pull request as ready for review September 27, 2024 15:40
@KendallWeihe
Copy link
Contributor Author

Ready for review, but still need to implement some of the foreign fetch pieces

#[wasm_bindgen]
extern "C" {
#[wasm_bindgen(
typescript_type = "{ fetch: (url: string, options?: WasmFetchOptions) => WasmResponse }"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did we land on this? This is the way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed the way, but a couple items to touch up subsequently...

  • There may be a slightly better way to define the typescript_type than inlining the attribute like this
  • @diehuxx and I have talked about a slight rework with the http-std crate in web5-rs which this currently utilizes
  • We need to make everything all the way down async ASAP, because right now I have a hacky workaround in typescript via worker threads

@KendallWeihe KendallWeihe force-pushed the kendall/bind-wasm-starter branch from ff640fd to 9e7925b Compare September 29, 2024 22:37
@KendallWeihe KendallWeihe merged commit 994e918 into main Sep 30, 2024
20 checks passed
@KendallWeihe KendallWeihe deleted the kendall/bind-wasm-starter branch September 30, 2024 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants