Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decal #577

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

damienmontastier
Copy link
Collaborator

@damienmontastier damienmontastier commented Jan 3, 2025

Issue #282 (Decal)

Local Playgroundpnpm run playground

Local Documentationpnpm run docs:dev


@alvarosabu, @andretchen0

I still have quite a few changes to make to the documentation and code! I'll certainly need feedback to improve the tool. I'll make a list of feedbacks below so you'll have the context of the points I need to review / modify. 🤙

For the moment, the documentation is not functional.


Description

Component based on the Three.js DecalGeometry class. It includes a debugging tool that makes it easy and intuitive to place Decals on a scene element.

Feedbacks

  • TresLeches doesn't work on the documentation Demo, but it does on the development mode Demo, do you have any ideas?
  • Would a refacto from TresLeches simplify my code?
  • The next version of Cientos with the events fix could allow me to use the Decal selection in a different way (on click).

I look forward to your feedbacks 😄

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 84a0bc9
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/677baf7a4d256200085f8aef
😎 Deploy Preview https://deploy-preview-577--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0
Copy link
Contributor

  • Would a refacto from TresLeches simplify my code?

Maybe Alvaro knows more, but afaik Leches is in limbo at the moment. He was working on a new API, but I think demands from other projects are keeping it from moving forward.

It's probably best to remove Leches from the docs demo, unless it absolutely needs it. I thought the functionality currently displayed looked great, even though Leches wasn't working.

Fwiw, I'm working on a reorg of the file structure/docs and will probably remove Leches from the demos I've worked on.

@andretchen0
Copy link
Contributor

The component works great!

@andretchen0
Copy link
Contributor

I've made a PR on tres/assets with the textures. Once that is merged, please use those links for the demos.

https://github.com/Tresjs/assets/pull/24/files

@andretchen0
Copy link
Contributor

The next version of Cientos with the events fix could allow me to use the Decal selection in a different way (on click).

Are you talking about this PR from Tres core?

If so, Alvaro marked that as v5, so it probably won't land in main anytime soon.

It's up to you if you want to wait for it or move forward in parallel.

@andretchen0
Copy link
Contributor

For the moment, the documentation is not functional.

Just FYI, I can't seem to get the playground to work. Is that what you mean with the above?

I get a white screen (no error message) here: http://localhost:5173/abstractions/decal

@andretchen0
Copy link
Contributor

Just a head's up, we're going to be simplifying the Cientos file structure after these changes are merged:

#563

A single component's files (docs, demos, component, tools) will live in a single folder.

There's nothing for you to do right now. Just wanted to give you a head's up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants