-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cascader): The Cascader component enforces isSelectIconRight to be false to prevent potential style conflicts that may arise when isSelectIconRight is set to true #3852 #4984
Open
sqq1992
wants to merge
22
commits into
alibaba-fusion:next
Choose a base branch
from
sqq1992:fix-issue-3852
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d609eac
refactor(Form): convert to TypeScript, improve docs and tests, close#…
FairyYang fa20c5d
refactor(Tab): rename to ts
xiaoshuaiShania d8fa7e9
refactor(Tab): ts & docs & test tools
xiaoshuaiShania d477e2c
refactor(Tab): fix comment issues
xiaoshuaiShania 4a9f576
refactor(DatePicker): rename to ts
eternalsky 4a1ec1d
refactor(DatePicker): improve ts
eternalsky b87f784
refactor(DatePicker): improve types and docs
eternalsky 25cdeac
refactor(DatePicker): improve tc
eternalsky 44b64b6
refactor(DatePicker): fix comment issues
eternalsky 796b5d8
refactor(Form): update form field options and dependencies
eternalsky b78641b
fix(Timeline): left content of timeline item cannot be styled correctly
eternalsky 539e1d1
fix(Grid): The style prop of Col in the Grid does not take effect
82a302f
fix(DatePicker2): after entering a customized date format and pressin…
GCHHCG 2c3be74
refactor(Shell): rename to ts
luolin-ck a512263
refactor(Shell): Upgrade tests and docs, convert to TypeScript
luolin-ck 8a5b18f
refactor(Shell): fix comment issue
luolin-ck 877eecd
refactor(Range): rename to ts
wangw11056 d93eda1
refactor(Range): convert to TypeScript, improve docs and tests
wangw11056 a2d3a59
chore(*): fix test:js ci failure
eternalsky 00456e2
refactor(TimePicker2): convert to TypeScript, impove docs and tests, …
FairyYang 1849be8
test(TreeSelect): make test more robust by using cy.spy()
eternalsky c1325b4
fix(CascaderSelect): The value of the menuProps attribute is passed b…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,7 +102,20 @@ export interface CascaderMenuProps extends CommonProps, MenuProps { | |
*/ | ||
export interface CascaderProps | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这里要加一个 remark |
||
extends Omit<HTMLAttributesWeak, 'onChange' | 'onSelect' | 'defaultValue'>, | ||
CommonProps { | ||
CommonProps, | ||
Omit< | ||
MenuProps, | ||
| 'value' | ||
| 'onChange' | ||
| 'onSelect' | ||
| 'defaultValue' | ||
| 'focusedKey' | ||
| 'onItemFocus' | ||
| 'focusable' | ||
| 'isSelectIconRight' | ||
| 'onBlur' | ||
| keyof CommonProps | ||
> { | ||
/** | ||
* 数据源 | ||
* @en data source | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去掉 lodash