Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): instantiate recommended fillers by default #1901

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Jan 8, 2025

Motivation

Instantiate RecommendedFillers by default.

Solution

  • RecommededFillers are added when the ProviderBuilder is instantiated using new() i.e ProviderBuilder::new() will now return FillProvider with the recommended fillers instantiated.
  • Users can opt-out of this behaviour using .disable_recommended_fillers().

For example, if a user want just wants cached_nonce_management. It can be achieved like so:

let provider = ProviderBuilder::new()
            .disable_recommended_fillers()
            .with_cached_nonce_management()
            .on_anvil();

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya changed the title Yash/default recommended fillers feat(provider): instantiate recommended fillers by default Jan 8, 2025
crates/contract/src/call.rs Outdated Show resolved Hide resolved
@yash-atreya yash-atreya marked this pull request as ready for review January 8, 2025 17:20
@yash-atreya yash-atreya requested a review from DaniPopes January 9, 2025 08:01
@DaniPopes DaniPopes requested a review from gakonst January 9, 2025 08:10
@yash-atreya
Copy link
Member Author

yash-atreya commented Jan 9, 2025

@gakonst @mattsse bump for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants