Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed prettier workflow to actually apply changes #2806

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

george-gca
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit 825b37a
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/6748bb9a87171800088c5e4c
😎 Deploy Preview https://deploy-preview-2806--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: George Araújo <[email protected]>
@george-gca george-gca force-pushed the new_prettier_workflow branch from 0203b6c to ed1e8b0 Compare October 24, 2024 18:52
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
Copy link
Owner

@alshedivat alshedivat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for simplifying the workflow

Comment on lines -22 to -23
- name: Install Prettier 💾
run: npm install --save-dev --save-exact prettier @shopify/prettier-plugin-liquid
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like prettier code formatter fails. you may need to keep this step.

@george-gca
Copy link
Collaborator Author

It is failing in the checkout code part, and honestly idk why. I even asked for help in actions/checkout#1326 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants