-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed prettier workflow to actually apply changes #2806
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: George Araújo <[email protected]>
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: George Araújo <[email protected]>
0203b6c
to
ed1e8b0
Compare
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for simplifying the workflow
- name: Install Prettier 💾 | ||
run: npm install --save-dev --save-exact prettier @shopify/prettier-plugin-liquid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like prettier code formatter fails. you may need to keep this step.
It is failing in the checkout code part, and honestly idk why. I even asked for help in actions/checkout#1326 (comment). |
No description provided.