remove setMode method #4561
remove setMode method #4561
Conversation
| @@ -22,7 +22,9 @@ export declare class Lexer extends Recognizer<number> { | |||
| nextToken(): Token; | |||
| skip(): void; | |||
| more(): void; | |||
| more(m: number): void; | |||
| mode(m: number): void; | |||
There was a problem hiding this comment.
can you add a setMode both here and in js and mark this one as deprecated ?
There was a problem hiding this comment.
What will be the next ANTLR version, i.e. from which version should it be marked as deprecated?
since 4.13.2?
| @@ -6,4 +6,7 @@ export declare class Recognizer<TSymbol> { | |||
|
|
|||
| removeErrorListeners(): void; | |||
| addErrorListener(listener: ErrorListener<TSymbol>): void; | |||
| getErrorListenerDispatch(): ErrorListener<TSymbol>; | |||
There was a problem hiding this comment.
can you rename to getErrorListener() and add to js ?
There was a problem hiding this comment.
... and I think the getErrorListenerDispatch method should be also marked as depricated in js.
| @@ -0,0 +1,60 @@ | |||
| import HashMap from "../src/antlr4/misc/HashMap.js"; | |||
There was a problem hiding this comment.
Looks like you need to rebase first
| @@ -6,4 +6,7 @@ export declare class Recognizer<TSymbol> { | |||
|
|
|||
| removeErrorListeners(): void; | |||
| addErrorListener(listener: ErrorListener<TSymbol>): void; | |||
| getErrorListenerDispatch(): ErrorListener<TSymbol>; | |||
| getLiteralNames(): string[] | []; | |||
There was a problem hiding this comment.
I don't think the type is correct. The array cannot be empty and it contains string | null elements
There was a problem hiding this comment.
I started from this.
I will correct it to:
getLiteralNames(): string[];
getSymbolicNames(): string[];
|
YesEnvoyé de mon iPhoneLe 18 mars 2024 à 18:14, Robert Einhorn ***@***.***> a écrit :
@RobEin commented on this pull request.
In runtime/JavaScript/src/antlr4/Lexer.d.ts:
@@ -22,7 +22,9 @@ export declare class Lexer extends Recognizer<number> {
nextToken(): Token;
skip(): void;
more(): void;
- more(m: number): void;
+ mode(m: number): void;
What will be the next ANTLR version, i.e. from which version should it be marked as deprecated?
since 4.13.2?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Added:
mode(...)getMode()(instead of_modefield)getModeStack()getErrorListenerDispatch()getLiteralNames()getSymbolicNames()INVALID_TYPEgetTokenSource()Removed (fixed):
more(m: number)method