-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the basemap schema and workflow #910
Open
bchapuis
wants to merge
38
commits into
main
Choose a base branch
from
basemaps-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+9,071
−5,992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prefix with osm_ - use singular names
- Use CREATE OR REPLACE for views - USE IF NOT EXISTS for materialized views
- Add license headers - Make everything more consistent
- Add missing license headers - Merge intermediary steps
- Add refresh scripts - Remove unused files - Improve formatting
bchapuis
force-pushed
the
basemaps-schema
branch
from
January 6, 2025 13:02
df16b67
to
4dd5ef4
Compare
bchapuis
force-pushed
the
main
branch
2 times, most recently
from
January 7, 2025 20:20
27dba59
to
767b079
Compare
bchapuis
force-pushed
the
basemaps-schema
branch
from
January 8, 2025 13:08
8b745fe
to
7b49d95
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general idea is to split the definition of the database schema from it's population with a workflow: one should be able to execute a workflow to create an empty schema and then to execute another workflow to populate it.
As these change require to rework most sql scripts, this PR also revise the different layers tries to apply the same recipes when dealing with different types of geometries types.