chore: Bump eslint (#384)

appium · Jan 8, 2025 · 62eab1a · 62eab1a
1 parent 8d3a63f
commit 62eab1a
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 31 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,5 @@
+import appiumConfig from '@appium/eslint-config-appium-ts';
+
+export default [
+  ...appiumConfig,
+];
diff --git a/lib/driver.js b/lib/driver.js
@@ -1,6 +1,6 @@
 import _ from 'lodash';
 import {BaseDriver, STANDARD_CAPS} from 'appium/driver';
-import Chromedriver from 'appium-chromedriver';
+import {Chromedriver} from 'appium-chromedriver';
 
 const CD_CONSTRAINTS = /** @type {const} */ ({
   chromedriverPort: { isNumber: true, },
@@ -23,7 +23,6 @@ const EDGE_VENDOR_PREFIX = 'ms:';
  * @extends {BaseDriver<CDConstraints>}
  * @implements {ExternalDriver<CDConstraints>}
  */
-// @ts-ignore
 export class ChromiumDriver extends BaseDriver {
   desiredCapConstraints = CD_CONSTRAINTS;
   _proxyActive = false;
@@ -32,7 +31,6 @@ export class ChromiumDriver extends BaseDriver {
   cd;
 
   /** @type {DriverOpts<CDConstraints>} */
-  // @ts-ignore
   opts;
 
   proxyReqRes;
@@ -63,7 +61,6 @@ export class ChromiumDriver extends BaseDriver {
    * @param {W3CChromiumDriverCaps} [w3cCapabilities]
    * @returns {Promise<[string,ChromiumDriverCaps]>}
    */
-  // @ts-ignore
   async createSession(
     jsonwpDesiredCapabilities,
     jsonwpRequiredCaps,
@@ -111,12 +108,10 @@ export class ChromiumDriver extends BaseDriver {
   /**
    *
    * @param {string} [sessionId]
-   * @param {DriverData[]} [driverData]
    * @returns {Promise<void>}
    */
-  async deleteSession(sessionId, driverData) {
-    // @ts-ignore
-    await super.deleteSession(sessionId, driverData);
+  async deleteSession(sessionId) {
+    await super.deleteSession(sessionId);
     this._proxyActive = false;
     this._bidiProxyUrl = null;
     this.proxyReqRes = null;

diff --git a/package.json b/package.json
@@ -91,7 +91,7 @@
   },
   "types": "./build/lib/driver.d.ts",
   "devDependencies": {
-    "@appium/eslint-config-appium": "^8.0.5",
+    "@appium/eslint-config-appium-ts": "^1.0.0",
     "@appium/tsconfig": "^0.x",
     "@appium/types": "^0.x",
     "@semantic-release/changelog": "^6.0.3",

diff --git a/test/e2e/driver.spec.js b/test/e2e/driver.spec.js
@@ -1,3 +1,4 @@
+/* eslint-disable mocha/no-top-level-hooks */
 import { waitForCondition } from 'asyncbox';
 import path from 'path';
 import {remote} from 'webdriverio';
@@ -133,7 +134,7 @@ describe('ChromeDriver', function() {
             try {
               networkResponses.should.not.be.empty;
               return true;
-            } catch (ign) {
+            } catch {
               return false;
             }
           },
@@ -142,7 +143,7 @@ describe('ChromeDriver', function() {
             intervalMs: 100,
           },
         );
-      } catch (err) {
+      } catch {
         networkResponses.should.not.be.empty;
       }
     });