Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #538: use 1 logger #637

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

slimus
Copy link
Contributor

@slimus slimus commented Oct 25, 2021

We used 2 different systems for logging.

Now I removed old log system and use one logger everywhere

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #637 (01526be) into master (9d47494) will decrease coverage by 1.01%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   65.05%   64.04%   -1.02%     
==========================================
  Files          21       21              
  Lines        1783     1808      +25     
==========================================
- Hits         1160     1158       -2     
- Misses        562      591      +29     
+ Partials       61       59       -2     
Impacted Files Coverage Δ
logx/log.go 37.73% <0.00%> (-11.05%) ⬇️
router/server.go 77.32% <100.00%> (+3.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d47494...01526be. Read the comment docs.

@appleboy
Copy link
Owner

@slimus Thanks for your effort. Maybe I can improve the gin/logger package not copy the source code from gin/logger.

@slimus
Copy link
Contributor Author

slimus commented Oct 26, 2021

It would be great :)

@slimus slimus marked this pull request as draft October 26, 2021 04:12
@appleboy appleboy force-pushed the master branch 2 times, most recently from 60a7a68 to 2c29b4b Compare June 30, 2022 15:02
@appleboy appleboy force-pushed the master branch 4 times, most recently from bff0f2d to 6b6ef69 Compare December 24, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants