Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving SDRAM.begin() on Arduino_H7_Video - Artifacts Issue Fix #1000

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Moving SDRAM.begin() on Arduino_H7_Video - Artifacts Issue Fix #1000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e989613
Moving SDRAM.begin() on Arduino_H7_Video library
Jorgetrujilloroman Nov 28, 2024
b46cb0b
Applying fix only on GIGA Target
Jorgetrujilloroman Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions libraries/Arduino_H7_Video/src/Arduino_H7_Video.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ int Arduino_H7_Video::begin() {
textFont(Font_5x7);
#endif

#if defined(ARDUINO_GIGA)
/* Configure SDRAM */
SDRAM.begin(dsi_getFramebufferEnd());
#endif

/* Video controller/bridge init */
_shield->init(_edidMode);

Expand Down Expand Up @@ -149,12 +154,14 @@ int Arduino_H7_Video::begin() {
disp_drv.sw_rotate = 1;
lv_disp_drv_register(&disp_drv); /* Finally register the driver */

#if !defined(ARDUINO_GIGA)
/* Configure SDRAM */
SDRAM.begin(dsi_getFramebufferEnd()); //FIXME: SDRAM init after video controller init can cause display glitch at start-up
#endif

#endif
#endif

/* Configure SDRAM */
SDRAM.begin(dsi_getFramebufferEnd()); //FIXME: SDRAM init after video controller init can cause display glitch at start-up

return 0;
}

Expand Down
Loading