Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some optimisations to the AccountId creation methods #985

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aleksuss
Copy link
Member

@aleksuss aleksuss commented Jan 9, 2025

Description

The PR introduces some optimisations to the creation methods of the AccounId struct. Namely, it gets rid of redundant heap allocations.

Performance / NEAR gas cost considerations

There is no changes in the performance.

Testing

The existing tests cover the changes.

@aleksuss aleksuss requested a review from mrLSD January 9, 2025 10:51
@aleksuss aleksuss requested a review from birchmd as a code owner January 9, 2025 10:51
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants