chore: added cascade delete sections in Has One and Has Many data mod… #8189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefaidt
reviewed
Jan 9, 2025
| @@ -439,6 +439,29 @@ do { | |||
|
|
|||
| </InlineFilter> | |||
|
|
|||
| ### Handling orphaned foreign keys on parent record deletion in "Has Many" relationship | |||
There was a problem hiding this comment.
this will show an empty section for mobile platforms, can we move the heading inside the filter?
There was a problem hiding this comment.
Sure will Update it and notify the mobile teams to add similar sections in swift, dart and android.
There was a problem hiding this comment.
sounds good! once mobile teams add snippets we can share this section's heading
josefaidt
reviewed
Jan 9, 2025
| @@ -794,6 +817,26 @@ val cart = Amplify.API.query( | |||
|
|
|||
| </InlineFilter> | |||
|
|
|||
| ### Handling orphaned foreign keys on parent record deletion in "Has One" relationship | |||
There was a problem hiding this comment.
Sure will Update it and notify the mobile teams to add similar sections in swift, dart and android.
josefaidt
previously approved these changes
Jan 9, 2025
bobbyu99
reviewed
Jan 9, 2025
| ```ts | ||
| // Get the IDs of the related members. | ||
| const { data: teamWithMembers } = await client.models.Team.get( | ||
| { id: teamId}, |
There was a problem hiding this comment.
nit:
Suggested change
| { id: teamId}, | |
| { id: teamId }, |
bobbyu99
reviewed
Jan 9, 2025
| @@ -794,6 +817,25 @@ val cart = Amplify.API.query( | |||
|
|
|||
| </InlineFilter> | |||
|
|
|||
| <InlineFilter filters={["javascript", "angular", "react-native", "react", "nextjs", "vue"]}> | |||
| ### Handling orphaned foreign keys on parent record deletion in "Has One" relationship | |||
There was a problem hiding this comment.
nit:
Suggested change
| ### Handling orphaned foreign keys on parent record deletion in "Has One" relationship | |
| ### Handling orphaned foreign keys on parent record deletion in "Has One" relationship |
bobbyu99
approved these changes
Jan 9, 2025
josefaidt
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Enhanced Documentation for Data Modeling Relationships
1. "Has One" Relationship Updates
2. "Has Many" Relationship Updates
Related GitHub issue #, if available:
Instructions and Testing
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.