added translation logic in tcp and udp emf log receivers to attach network attributes for emf logs #1491
+56
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Describe the problem or feature in addition to a link to the issues.
We want the ability to send entities for customers forwarding EMF logs using the EMF forwarding plugin: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Embedded_Metric_Format_Generation_CloudWatch_Agent.html
To build entity, we should be able to retrieve the EMF log sender IP address.
Description of changes
How does this change address the problem?
TCP and UDP logs receiver has an already built config option
add_attributes
which adds net.* attributes according to [semantic convention][https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/span-general.md#general-network-connection-attributes]https://github.com/amazon-contributing/opentelemetry-collector-contrib/tree/aws-cwa-dev/receiver/tcplogreceiver
https://github.com/amazon-contributing/opentelemetry-collector-contrib/tree/aws-cwa-dev/receiver/udplogreceiver
Added translation logic to enable this additional config in TCP and UDP logs receiver translator.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.
Unit Testing and Manual Testing
Testing details
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint