feat(appsync): add L2 constructs for AWS AppSync Events #32505
+9,444
−260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appsync events bricep
github-actions
bot
added
effort/medium
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
previously requested changes
Dec 13, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
1 task
kwwendt
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mergify
bot
dismissed
godwingrs22’s stale review
Pull request has been modified.
godwingrs22
previously requested changes
Dec 27, 2024
packages/aws-cdk-lib/aws-appsync/test/appsync-channel-namespace.test.ts
Outdated
Show resolved
Hide resolved
mergify
bot
dismissed
godwingrs22’s stale review
Pull request has been modified.
gracelu0
removed
the
pr/needs-maintainer-review
aws-cdk-automation
added
the
pr/needs-maintainer-review
godwingrs22
reviewed
Dec 31, 2024
godwingrs22
added
the
needs-security-review
1 task
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #32004
Reason for this change
This is in support of AWS AppSync Events.
Description of changes
EventApiandChannelNamespaceto support AWS AppSync Events.EventApiandGraphqlApiconstructs.EventApiandGraphqlApiconstructs.Description of how you validated changes
Added both unit and integration tests for AWS AppSync Event API changes.
Contributors
@mazyu36 @onlybakam @kwwendt
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license