chore(eslint): enforce no extra semicolons #32724
Conversation
github-actions
bot
added
p2
repeat-contributor
| }; | ||
| } |
There was a problem hiding this comment.
There seems to be no eslint rule regarding semicolons in interface definitions, but the overwhelming majority of interface definitions in this file do not have semicolons.
Therefore, we believe that this semicolon should also be removed.
There was a problem hiding this comment.
If this modification is not needed, I'll remove it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32724 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 222 222
Lines 13715 13715
Branches 2417 2417
=======================================
Hits 11181 11181
Misses 2254 2254
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-community-review
| @@ -927,7 +927,7 @@ export class UserPool extends UserPoolBase { | |||
|
|
|||
| const userPoolId = arnParts.resourceName; | |||
| // ex) cognito-idp.us-east-1.amazonaws.com/us-east-1_abcdefghi | |||
| const providerName = `cognito-idp.${arnParts.region}.${Stack.of(scope).urlSuffix}/${userPoolId}`;; | |||
| const providerName = `cognito-idp.${arnParts.region}.${Stack.of(scope).urlSuffix}/${userPoolId}`; | |||
There was a problem hiding this comment.
👍 There are 18 occurrences of ;; in the project at the moment. It would be nice to adjust the other 17 as well.
There was a problem hiding this comment.
would be similarly amazing to figure out why its happening and/or add a linter rule against it
There was a problem hiding this comment.
@lpizzinidev @kaizencc
added @stylistic/js/no-extra-semi rule.
aws-cdk-automation
removed
the
pr/needs-community-review
yasuaki640
changed the title
yasuaki640
force-pushed
the
remove-uneccessary-semicolon
branch
from
8476a31 to
42d501b
Compare
yasuaki640
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
kaizencc
changed the title
yasuaki640
force-pushed
the
remove-uneccessary-semicolon
branch
from
42d501b to
7e3f10d
Compare
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
yasuaki640
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
yasuaki640
force-pushed
the
remove-uneccessary-semicolon
branch
from
19e500a to
b0a9b4a
Compare
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes N/A
Reason for this change
I would like to reduce noise during development by reducing the number of warnings output by the IDE.
Description of changes
Removed unneccessary semicolon.
Describe any new or updated permissions being added
<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license