Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: correct comment syntax in PR template for IAM permissions #32793

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore: correct comment syntax in PR template for IAM permissions #32793

wants to merge 7 commits into from
+1 −1

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jan 8, 2025

The comment regarding IAM permissions was not properly commented out.
So I've fixed.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 8, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 8, 2025 06:56
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jan 8, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 8, 2025
kaizencc
kaizencc previously approved these changes Jan 8, 2025
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 8, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaizencc
Copy link
Contributor

kaizencc commented Jan 8, 2025

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 8, 2025

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@kaizencc
Copy link
Contributor

kaizencc commented Jan 9, 2025

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

update

✅ Branch has been successfully updated

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (aff160b) to head (97c81cf).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32793   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         222      222           
  Lines       13717    13717           
  Branches     2417     2417           
=======================================
  Hits        11183    11183           
  Misses       2254     2254           
  Partials      280      280
Flag Coverage Δ
suite.unit 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.98% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jan 9, 2025

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

update

☑️ Nothing to do

  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jan 9, 2025

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@moelasmar moelasmar closed this Jan 9, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32793 has been dequeued, merge conditions unmatch:

  • -closed
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of [🛡 GitHub branch protection]:
    • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = validate-pr
    • check-skipped = validate-pr
    • check-success = validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-neutral = codecov/patch/packages/aws-cdk
    • check-skipped = codecov/patch/packages/aws-cdk
    • check-success = codecov/patch/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-neutral = codecov/project/packages/aws-cdk
    • check-skipped = codecov/project/packages/aws-cdk
    • check-success = codecov/project/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-neutral = codecov/patch/packages/aws-cdk-lib/core
    • check-skipped = codecov/patch/packages/aws-cdk-lib/core
    • check-success = codecov/patch/packages/aws-cdk-lib/core
  • any of [🛡 GitHub branch protection]:
    • check-neutral = codecov/project/packages/aws-cdk-lib/core
    • check-skipped = codecov/project/packages/aws-cdk-lib/core
    • check-success = codecov/project/packages/aws-cdk-lib/core
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -label~=(blocked|do-not-merge|no-squash)
  • -merged
  • -title~=(WIP|wip)
  • base!=release

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@moelasmar moelasmar reopened this Jan 9, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
@aws aws unlocked this conversation Jan 9, 2025
@mergify mergify bot dismissed kaizencc’s stale review January 9, 2025 11:58

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 9, 2025
@moelasmar
Copy link
Contributor

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

refresh

✅ Pull request refreshed

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jan 10, 2025

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 97c81cf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mazyu36 @kaizencc @moelasmar @aws-cdk-automation