Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing of EC public keys, get format #519

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Sep 9, 2024

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 35 lines in your changes missing coverage. Please review.

Project coverage is 92.67%. Comparing base (c358484) to head (9132154).
Report is 137 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/agreement.rs 72.50% 19 Missing and 3 partials ⚠️
aws-lc-rs/src/ec.rs 86.45% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   95.80%   92.67%   -3.13%     
==========================================
  Files          61       67       +6     
  Lines        8143     9792    +1649     
  Branches        0     9792    +9792     
==========================================
+ Hits         7801     9075    +1274     
- Misses        342      428      +86     
- Partials        0      289     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants