-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide client config property for region provider #1488
base: main
Are you sure you want to change the base?
Conversation
A new generated diff is ready to view. |
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
A new generated diff is ready to view. |
A new generated diff is ready to view. |
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsKotlinDependency.kt
Outdated
Show resolved
Hide resolved
codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsServiceConfigIntegration.kt
Outdated
Show resolved
Hide resolved
A new generated diff is ready to view. |
Quality Gate passedIssues Measures |
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a very broad question before I dive into a detailed line-by-line review.
/** | ||
* Adds region provider integration to the client config | ||
*/ | ||
class RegionProviderIntegration : KotlinIntegration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Why is this separate from the RegionSupport
integration that exists in smithy-kotlin? They serve the exact same purpose, just via slightly different mechanisms. Moreover, any non-AWS service which is regionalized and supports a static region
config prop should also support a regionProvider
prop shouldn't it?
Issue #
#1478
Description of changes
This PR introduces
regionProvider
property to client config in the AWS SDK for Kotlinrelated PR: smithy-lang/smithy-kotlin#1210
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.