Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactoring terraform #720

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

namejsjeongkr
Copy link

@namejsjeongkr namejsjeongkr commented Jan 5, 2025

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • I'd like to suggest a consistent refactoring of terraform. In my opinion, the code currently written is inconsistent. (If you look at terraform codes of multiple services in the ai-ml folder, the code isn't written consistently for each service. local, provider and so on.)
  • The committed code is the sample I'd like to suggest. If you give me additional comments, I'd to revise the rest of the codes as well.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@namejsjeongkr namejsjeongkr changed the title Refactoring terraform fix: Refactoring terraform Jan 5, 2025
@namejsjeongkr
Copy link
Author

namejsjeongkr commented Jan 6, 2025

@dorukozturk @vara-bonthu @askulkarni2 Do you mind if I ask you to review this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant