-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial version of the Listenbrainz plugin #5058
Conversation
Awesome! This already looks fantastic! No objection to merging right away if you think this is at a usable initial state. I also noticed this contains a few changes to the last.fm plugin. Was that intentional? I didn't review them carefully, although they seem credible. If they fix bugs in the plugin, maybe that deserves a changelog entry of its own. |
@sampsyo Yes, I have tested it, and it is ready to be merged. I made minor changes to the |
Sometimes, there are other playlists that are created (e.g., Top Missed Recordings of 2023, Top Discoveries of 2023). Right now, I am excluding these. We may want to address them separately.
Sounds good! Would you mind summarizing the changes to |
Correct me if I'm wrong, but this seems to be fetching the whole ListenBrainz history on each run - could we leverage |
Yes, all the elements could (and should) be configured. We still need to carefully think about how to use them (which is why I called this PR The current code has been reviewed and approved by @sampsyo, so I would not change it. Once this PR is merged, we can create a feature request for additional configurations and discuss the best approach to implement the same. |
I'll merge this then, since it's been approved. I should note that I have attempted my own tool for listenbrainz here, though it is implemented in Rust instead of Python. I still have to reach out to the listenbrainz team to try and get the song matching working as well as it can. Right now I can get it to about 90%+ but still not 100%. |
@Serene-Arc I will try to extend this plugin to include playlist uploads. The song-matching issue could be on LB's end...see a related issue. |
Description
Fixes #1719
I added a basic version of the LB plugin that imports the play history. It uses the same process used in the Lastimport plugin to update playcounts.
There are few additional functions that I added here to import playlists created by Listenbrainz. These playlists can then be imported in other programs such as Plex.
To Do
docs/
to describe it.)docs/changelog.rst
to the bottom of one of the lists near the top of the document.)