Changed the horizontal scroll for the python output #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dio from the python cell
lucasfcosta
requested changes
Oct 5, 2024
There was a problem hiding this comment.
Hey @joezein-oss! Thanks a lot for this!
I think @vieiralucas and I poorly described the desired behaviour - this is not the desired change.
What we want is for the long lines of text to "wrap" (text-wrap: unset; on the pre containing the text would be enough).
In case there's a large image/plotly output (and it overflows the block) then the whole block should scroll together if possible.
Do you think we could change the behaviour this way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
overflow-x-scrollif there'sstdioin the list of python outputs. This change will make the whole block scrollable if there's a python stdio, which will include the graph too. So if there's python text output and aplotlygraph, the graph will also be in the scrollable block. If this is not desirable, let me know and I'll try to find another method to fix this (maybe group text blocks with each other).Closes #97