[JN-1551] cleanup issues with multiple 'other' on checkboxes #1373
+284
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Since the other questions weren't "real" questions they weren't showing up in the enrollee overview page for surveys. Since we relied on full surveyjs questions, I refactored it to use a more condensed type of only the things we need to know - this has the advantage of a lot less ugly casting and typescript workarounds across the page.
Also, variables (profile.givenName, etc.) weren't being rendered
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)