-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move handler config out of frame meta to a configuration script #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er closure: assert we can use our custom commands to load an initial env variable, and then work with it
…dler nushell script preamble
…with process: <closure>
…ration script return record
cablehead
force-pushed
the
feat-handler-preserve-env
branch
from
January 1, 2025 21:47
9969998
to
4df2e02
Compare
cablehead
force-pushed
the
feat-handler-preserve-env
branch
from
January 1, 2025 22:26
68fda01
to
caaad92
Compare
cablehead
changed the title
feat: preserve engine env between handler calls
feat: move handler config out of frame meta to a configuration script
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move handler configuration from register frame metadata to a record returned by the
handler configuration script. This allows using Nushell code for configuration, making
it more powerful and flexible (e.g. resume_from can use Nushell to locate the right
frame ID).
Config record fields:
Other changes: