-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Local segment manager memory leak fix #3340
Open
tazarov
wants to merge
2
commits into
trayan-12-13-fix_delete_collection_resource_leak
Choose a base branch
from
trayan-12-19-fix_local_segment_manager_memory_leak_fix
base: trayan-12-13-fix_delete_collection_resource_leak
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[BUG]: Local segment manager memory leak fix #3340
tazarov
wants to merge
2
commits into
trayan-12-13-fix_delete_collection_resource_leak
from
trayan-12-19-fix_local_segment_manager_memory_leak_fix
+25
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
1 task
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
tazarov
added
bug
Something isn't working
Local Chroma
An improvement to Local (single node) Chroma
labels
Dec 19, 2024
tazarov
force-pushed
the
trayan-12-13-fix_delete_collection_resource_leak
branch
from
January 2, 2025 07:19
2cd4f74
to
e3807a9
Compare
tazarov
force-pushed
the
trayan-12-19-fix_local_segment_manager_memory_leak_fix
branch
2 times, most recently
from
January 2, 2025 16:06
e3406df
to
a8d1954
Compare
tazarov
force-pushed
the
trayan-12-13-fix_delete_collection_resource_leak
branch
from
January 3, 2025 07:48
2e113a0
to
b53dadb
Compare
tazarov
force-pushed
the
trayan-12-19-fix_local_segment_manager_memory_leak_fix
branch
from
January 3, 2025 07:48
a8d1954
to
47f8d3c
Compare
tazarov
force-pushed
the
trayan-12-13-fix_delete_collection_resource_leak
branch
from
January 8, 2025 08:21
b53dadb
to
ba07228
Compare
tazarov
force-pushed
the
trayan-12-19-fix_local_segment_manager_memory_leak_fix
branch
from
January 8, 2025 08:21
47f8d3c
to
4435b8d
Compare
tazarov
force-pushed
the
trayan-12-19-fix_local_segment_manager_memory_leak_fix
branch
from
January 8, 2025 14:24
4435b8d
to
de5b03c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #3336
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
N/A
Some 12h later: