-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Athena webrtc streamer #34226
base: master
Are you sure you want to change the base?
Athena webrtc streamer #34226
Conversation
Recording.2024-12-12.215222.mp4 |
Recording.2024-12-12.220040.mp4 |
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
Cool! How well does this work over cell? Ultimately, I'd like to replace snapshot in connect with a live stream. |
It works reliably well. I created my own TURN server using coturn so it relays through that when using mobile data. You obviously need a decent cell connection for live streaming. Even with a bad connection it will still send some frames. WebRTC is robust to connection interruptions but since its using athena, if the websocket connection times out, it will set the end_event and reset everything. |
@adeebshihadeh The video I posted was using a turn server over mobile hotspot, not the local network. |
are we able to implement this for connect? this would a great addition or does it add too much server traffic? |
It could put a strain on the servers bandwidth if there was hundreds of simultanious streams. But this could be easily managed. Konik connect has already added support for it for free if you want it. |
I am sorry, whats Konik connect? is that a connect fork? How do I use it? Do I also need a different openpilot branch? |
Yea its a connect fork and requires a fork of openpilot. Setup info in the discord https://discord.gg/2wvNf4gw |
Not expecting a merge, just showing this working demo of how webrtc could be used with connect in the future.