Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to conda 23.10 and mamba 1.5.3 #518

Merged
merged 8 commits into from
Nov 26, 2023
Merged

Update to conda 23.10 and mamba 1.5.3 #518

merged 8 commits into from
Nov 26, 2023

Conversation

mbargull
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

closes gh-496
closes gh-511

Continuation of gh-496 using setup-miniconda for macOS and updating to conda-libmamba-solver=23.11.1.

@mbargull mbargull requested a review from a team as a code owner November 20, 2023 20:16
@mbargull mbargull mentioned this pull request Nov 20, 2023
Closed
5 tasks
@mbargull mbargull force-pushed the hmaarrfk/update_mamba branch from 056604d to dd7f8bd Compare November 20, 2023 20:24
mbargull
mbargull commented Nov 20, 2023
View reviewed changes
build_miniforge_osx.sh

export CONSTRUCT_ROOT="${PWD}"
mkdir -p build
eval "$(PS1="${PS1-}" conda shell.posix activate)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't look into what setup-miniconda does with its auto-activate-base option.
Tried it in 056604d but didn't work.
I'm fine with doing the manual shell.posix activate, but if anyone wants to try/use setup-miniconda's functionality properly, feel free to amend this!

@mbargull
Copy link
Member Author

(FYI: I restarted failed CI jobs twice. Some Linux-aarch64 builds stalled for some reason. https://github.com/conda-forge/miniforge/actions/runs/6935425583/attempts/1 )

@hmaarrfk hmaarrfk closed this Nov 26, 2023
@hmaarrfk hmaarrfk reopened this Nov 26, 2023
@hmaarrfk
Copy link
Contributor

Restarted all the CI jobs. Will merge once it passes.

@mbargull
Copy link
Member Author

mbargull commented Nov 26, 2023 •
edited
Loading

Restarted all the CI jobs. Will merge once it passes.

Shall we rather wait a couple of days and discuss on the next core if we want to go with conda=23.10 or rather wait for a 23.11 which will (hopefully) include fixes for better conda-build<->conda-libmamba-solver integration?
(Even though conda-build is not part of Miniforge, it's still used for build setups and conda>=23.10's default solver change can thus affect those.)

@hmaarrfk
Copy link
Contributor

I don't really see the point in waiting a couple of days.

Generally speaking, I wanted to stop users from being "force to downgrade any package" in the case that boa needed to be installed.

This is a standard usecase for conda's base installer.

However, today in most feedstocks:

 conda                     23.10.0         py310hff52083_1    conda-forge
 mamba                     1.5.3           py310h51d5547_2    conda-forge

The latest build I triggered was in conda-forge/boa-feedstock#76, thus I feel like we should update this.

I have an other fear, if we do this these updates too quickly, we don't give time to catch all the conda bugs.

Thus I typically like to "wait" a little bit.

@hmaarrfk hmaarrfk merged commit e4d124e into conda-forge:main Nov 26, 2023
72 checks passed
@mbargull
Copy link
Member Author

I don't follow.

The latest build I triggered was in conda-forge/boa-feedstock#76, thus I feel like we should update this.

Why "thus"?

I have an other fear, if we do this these updates too quickly, we don't give time to catch all the conda bugs.

Thus I typically like to "wait" a little bit.

We do have the case that 23.10 has (impactful) bugs (surfaced via the solver: libmamba default change) -- which means we are in a "catch conda bugs" phase right now warranting to "wait a little bit"...

It is rather strange to ignore raised concerns.

@isuruf
Copy link
Member

isuruf commented Nov 26, 2023

@hmaarrfk, shall we wait until Wednesday to discuss the changes and keep the release as pre-release for now?

@hmaarrfk
Copy link
Contributor

Sorry about this. sigh. ok. I think I need to spend more time following the condo/boa/libmamba bugs.

let's leave it as a draft until things are resolved....

just I don't doubt we will have more bugs in 23.11

@hmaarrfk
Copy link
Contributor

Why "thus"?

more like "it didn't give me any problems" and this upgrade "avoids a regular cycle of updates for every build".

however. I was unaware of the impact of the latest bugs.

hmaarrfk added a commit to hmaarrfk/miniforge that referenced this pull request Nov 26, 2023
@hmaarrfk
Revert "Merge pull request conda-forge#518 from mbargull/hmaarrfk/upd…
486c662 
…ate_mamba"

This reverts commit e4d124e, reversing
changes made to 1a3e858.
@hmaarrfk hmaarrfk mentioned this pull request Nov 26, 2023
Closed
5 tasks
hmaarrfk added a commit to hmaarrfk/miniforge that referenced this pull request Nov 26, 2023
@hmaarrfk
Revert "Revert "Merge pull request conda-forge#518 from mbargull/hmaa…
9ca5116 
…rrfk/update_mamba""

This reverts commit 486c662.
@hmaarrfk hmaarrfk mentioned this pull request Nov 26, 2023
Closed
@mbargull
Copy link
Member Author

however. I was unaware of the impact of the latest bugs.

Ah, I thought you were aware (through core chat, my comment on your original PR, etc.).
To give context: These bugs aren't even new, but just more likely to encounter since conda=23.10 changed its default to solver=libmamba.
As such, it is more of a "make things less likely/immediately to break for users" thing than "ship things broken" as of now.
I don't know whether we get a conda=23.11.0/conda=23.10.1 quickly, but I hope to get answers to that on Wednesday.

@jaimergp
Copy link
Member

23.11 should be tagged this week, AFAIK.

@jakirkham
Copy link
Member

jakirkham commented Nov 29, 2023 •
edited
Loading

Did we add this to the agenda tomorrow?

Edit: Turns out I added it 2 weeks ago and now it is first up 🙂

@jakirkham
Copy link
Member

jakirkham commented Nov 29, 2023 •
edited
Loading

Conclusion from the meeting today is that we wait until there is a new Conda release (tentatively planned this week)

Edit: This is also being added to the next meeting in 2 weeks for follow-up (unless it has already been handled before then)

@jakirkham
Copy link
Member

Looks like Conda 23.11.0 just came out 🎉

xref: conda-forge/conda-feedstock#228

hmaarrfk added a commit to hmaarrfk/miniforge that referenced this pull request Dec 3, 2023
@hmaarrfk
Revert "Merge pull request conda-forge#518 from mbargull/hmaarrfk/upd…
92d9b99 
…ate_mamba"

This reverts commit e4d124e, reversing
changes made to 1a3e858.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release 23.10
5 participants
@mbargull @hmaarrfk @isuruf @jaimergp @jakirkham