Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ILayoutEngines perform custom actions #736

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Dec 22, 2023

This PR adds the ability for layout engines to perform non-standard actions, and still have their resulting layouts be saved to Workspace instances. This was needed for #634, where the SliceLayoutPlugin tries to perform operations on the SliceLayoutEngine, but was unable to save the resulting ILayoutEngine instance to the Workspace.

The PerformCustomAction method can be used by ILayoutEngine implementations to perform non-standard actions.

@dalyIsaac dalyIsaac added enhancement New feature or request core Whim labels Dec 22, 2023
@dalyIsaac dalyIsaac linked an issue Dec 22, 2023 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ca758ae) 79.73% compared to head (5bdced4) 79.83%.

Files Patch % Lines
src/Whim/Layout/LayoutEngineCustomAction.cs 60.00% 2 Missing ⚠️
src/Whim.FloatingLayout/FloatingLayoutEngine.cs 87.50% 0 Missing and 1 partial ⚠️
src/Whim.TestUtils/TestLayoutEngine.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
+ Coverage   79.73%   79.83%   +0.09%     
==========================================
  Files         179      180       +1     
  Lines        8814     8877      +63     
  Branches      990      996       +6     
==========================================
+ Hits         7028     7087      +59     
- Misses       1672     1675       +3     
- Partials      114      115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review December 22, 2023 09:49
@dalyIsaac dalyIsaac merged commit 18bbcb1 into main Dec 22, 2023
7 checks passed
@dalyIsaac dalyIsaac deleted the 735-let-ilayoutengines-perform-custom-actions branch December 22, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let ILayoutEngines perform custom actions
1 participant