Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v2024.12 and Dynamic CSS #186

Merged
merged 7 commits into from
Dec 28, 2024

Conversation

BlackDex
Copy link
Collaborator

@BlackDex BlackDex commented Nov 21, 2024

Update web-vault to v2024.11

Removed the access-intelligence since this is linked to Bitwarden Licensed code.

stefan0xC and others added 2 commits November 6, 2024 15:49
- This PR includes the changes from @stefan0xC done in dani-garcia#182
- It also adds the dynamic-css support

Removed the access-intelligence since this is linked to Bitwarden Licensed code.

Signed-off-by: BlackDex <[email protected]>
@BlackDex
Copy link
Collaborator Author

@stefan0xC i based this PR upon yours and updated to v2024.11.1 and added dynamic-css here.
The web-vault built using this PR can be used with dani-garcia/vaultwarden#5219

It would be nice if people are able to test this web-vault with the code in the PR at the Vaultwarden repo.
And then mainly the whole manager role and access-all etc...

- Moved v2023 patches to legacy
- Updated .gitignore and .dockerignore and synced them
- Added a CODEOWNERS file
- Updated workflows
@BlackDex BlackDex changed the title Update to v2024.11 Update to v2024.11 and Dynamic CSS Nov 25, 2024
@BlackDex BlackDex marked this pull request as ready for review November 25, 2024 16:23
@BlackDex
Copy link
Collaborator Author

This PR using v2024.11.1 web-vault version only works with this pending PR dani-garcia/vaultwarden#5219 .

Several changes were needed on the server side to use the Custom Role as a Manger role and still be compatible with a previous version of Vaultwarden in case someone needs/wants to rollback. So do not try to use this PR with any version equal to or older then v1.32.5, it will not work.

@BlackDex BlackDex requested a review from dani-garcia November 25, 2024 16:44
A security patch has just been released, update to this version.
Add some other modifications like removing stripe, braintree and paypal keys.

Signed-off-by: BlackDex <[email protected]>
@BlackDex
Copy link
Collaborator Author

I Updated to the just released v2024.11.2 security patch.

@BlackDex
Copy link
Collaborator Author

I'm checking to see if i can update to v2024.12

@BlackDex BlackDex changed the title Update to v2024.11 and Dynamic CSS Update to v2024.12 and Dynamic CSS Dec 11, 2024
@BlackDex
Copy link
Collaborator Author

Ok, i have updated it to use v2024.12.0. Not too much was changed. A file was relocated and some colors have changed a bit.

Also needed to make some changes on the server-side for this, but not too much either.

@dfunkt
Copy link
Contributor

dfunkt commented Dec 11, 2024

Is there any point in keeping the v2024.10.5 and v2024.11.2 patch files since they're now outdated/not used in any build?

@BlackDex
Copy link
Collaborator Author

Might be useful for historical usage or comparing what was changed.
It also doesn't harm to have them.

@BlackDex BlackDex merged commit 1699ce9 into dani-garcia:master Dec 28, 2024
1 check passed
@BlackDex BlackDex deleted the update-to-v2024.11 branch December 28, 2024 15:46
@BlackDex BlackDex mentioned this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants