0.7.0 Release
#255
Open
0.7.0 Release
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Uv2 sync to use batch contracts
…estry/pamms-rs into 0xkitsune/discovery-sync
Osiris/balancer
docs(amm): Adding an AMM
feat(amms): Add `Token` type instead of specifying `token_address` and `token_decimals` directly on pool.
Implement `From<Address>` for `Token`
henopied
reviewed
Dec 31, 2024
| function liquidity() external view returns (uint128); | ||
| } | ||
|
|
||
| // /** |
| /// @title Pool state that can change | ||
| /// @notice These methods compose the pool's state, and can change with any frequency including multiple times | ||
| /// per transaction | ||
| interface IUniswapV3PoolState { |
| } | ||
| } | ||
|
|
||
| pub fn q64_to_float(num: u128) -> Result<f64, AMMError> { |
There was a problem hiding this comment.
dedupe with utils in src/amms/float.rs?
| self.state.keys().cloned().collect() | ||
| } | ||
|
|
||
| /// Calculates a f64 representation of base token price in the AMM. This is a "tax inclusive" spot approximation. |
There was a problem hiding this comment.
It appears that the other pools don't include fees in this method. I think either approach is ok, but should probably be consistent and specified in the trait doc.
|
|
||
| current_state.amount_calculated -= I256::from_raw(step.amount_out); | ||
|
|
||
| // TODO: adjust for fee protocol |
There was a problem hiding this comment.
Does protocol fee matter for us? My understanding is that comes out of the fees already paid.
| .cloned() | ||
| .map(|amm| { | ||
| let pool_address = amm.address(); | ||
| // TODO FIXME: Need to update this when we have balancer/v3 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #235