Don't actually close DB connections during tests #2101
Merged
+85
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2024
This is effectively a combination of a modernization of django@9ae27cb and @adamchainz's minimal repro: django#1091 (comment)
bigfootjon
force-pushed
the
tests-no-close-connections
branch
from
b9331c6 to
2fe5b2b
Compare
carltongibson
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
I think we should advance this, thanks @bigfootjon.
My only consideration is to make sure we call out the change in the release notes for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively a combination of a modernization of 9ae27cb and @adamchainz's minimal repro: #1091 (comment)
Refs: #2090
Closes: #1091
Closes: #1290
I fought with django for some time to try and convince it to use my overridden DB connection just inside these unit tests but it wasn't biting. I opted instead to just modify channels' global django settings