-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pyproject, bump pyupgrade #542
base: main
Are you sure you want to change the base?
Conversation
@carltongibson, how do you feel about these changes? These seem reasonable to me, but I'm not terribly familiar with the release process nor any opinions you might have about the tools in-use |
@bigfootjon Yes, thanks. I have a few thoughts before merging this. (I need to think them through fully yet 😅) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I had a closer look.
TBH I'd rather scope this down to just the smaller project data move, and the pyupgrade shift, leaving the tool configuration where it is.
We could have a .flake8
and move the pytest
etc maybe, but I want to keep the tox config where it is.
.gitignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing the value of the changes to this file.
e.g. this adds nothing:
# Tox
/.tox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I would lean towards commenting the gitignores so if and when you switch tooling you can update.
Github's template provides this example comment for tox though I don't think that's quite accurate.
# Unit test / coverage reports
https://github.com/github/gitignore/blob/main/Python.gitignore
I'll remove them though, feel free to edit the PR.
@asears This is looking good thanks. I just need a moment to pull it locally and I will bring it in. Nice one. 🎁 |
This PR uplifts the project a bit. ++ @carltongibson
and tox.ini- Comment the gitignore, add coverage exclusionsThis PR will need a test by someone familiar with the release process and review of the settings for pypi release.
Some further improvements could be made: