[Android] Top bar item colors - fix

[kubaflo]

Description

Android docs: https://developer.android.com/reference/com/google/android/material/tabs/TabLayout#setTabIconTint(android.content.res.ColorStateList)

An easy fix is to just add _tabLayout.TabIconTint = colors; I did it in the first commit. However, I've noticed that thanks to it there's no longer need to have SetIconColorFilter() method, and, thereby, significantly reduce the size and complexity of this class. But maybe I'm missing something 🤔

Issues Fixed

Fixes #26905
Fixes #26662

Before	After
Screen.Recording.2025-01-05.at.19.53.17.mov	Screen.Recording.2025-01-05.at.19.54.38.mov

@jsuarezruiz what do you think?

[dotnet-policy-service]

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[jfversluis]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[Tamilarasan-Paranthaman]

@kubaflo, I believe removing SetIconColorFilter is not appropriate, as it could cause issues in certain scenarios involving FontImageSource color.

Recently, I fixed the FontImageSource color issue on the TabbedPage icon. The PR can be found here: [iOS] [Android] Fix for the FontImageSource color is not applied properly to the Tab Icon by Tamilarasan-Paranthaman · Pull Request #26757 · dotnet/maui

For instance, if there are two ContentPage instances as children of a TabbedPage, setting SelectedTabColor to red while applying different FontImageSource colors to each page may not work as expected.

The SetIconColorFilter method handles the Icon.InvalidateSelf call, ensuring that the icon is updated correctly.

[kubaflo]

Hi @Tamilarasan-Paranthaman this pr actually fixes the issue in your PR. And there's no need for SetIconColorFilter

Screen.Recording.2025-01-06.at.18.09.05.mov

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[rmarinho]

Can we make sure adding a menu item and disable and enable it with have the correct colors?

[Tamilarasan-Paranthaman]

Hi @Tamilarasan-Paranthaman this pr actually fixes the issue in your PR. And there's no need for SetIconColorFilter

Screen.Recording.2025-01-06.at.18.09.05.mov

@kubaflo, can you please fully utilize my test sample? I have added the SelectedTabColor and UnSelectedTabColor, but no FontImageSource color is specified for the first page. Only the second and third pages have the FontImageSource color defined.

With your fix, the FontImageSource color is not applied to the second and third pages.

I have handled the FontImageSource color for different scenarios by using combinations of SelectedTabColor, UnSelectedTabColor, and the FontImageSource color in my PR. It works properly.