Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range-selector): range-selector can not blur #3967

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Nov 6, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 6, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  7311b36
info  For more information, see full report

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 32.70%. Comparing base (238eef1) to head (7311b36).

Files with missing lines Patch % Lines
...ets-ui/src/views/permission/panel-detail/index.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3967      +/-   ##
==========================================
- Coverage   32.70%   32.70%   -0.01%     
==========================================
  Files        2439     2439              
  Lines      126528   126529       +1     
  Branches    28335    28335              
==========================================
  Hits        41380    41380              
- Misses      85148    85149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug confirmed. We need a more generic solution.

};

useSidebarClick(handlePanelClick);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook is suspicious. What about other focusable elements not in the panel, especially considering we are an SDK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This focused state is left entirely to the external business of the component (different cases have different defocusing moments)

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants