-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(range-selector): range-selector can not blur #3967
base: dev
Are you sure you want to change the base?
Conversation
View Deployment
|
Playwright test resultsDetails 19 tests across 9 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3967 +/- ##
==========================================
- Coverage 32.70% 32.70% -0.01%
==========================================
Files 2439 2439
Lines 126528 126529 +1
Branches 28335 28335
==========================================
Hits 41380 41380
- Misses 85148 85149 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug confirmed. We need a more generic solution.
}; | ||
|
||
useSidebarClick(handlePanelClick); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hook is suspicious. What about other focusable elements not in the panel, especially considering we are an SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This focused state is left entirely to the external business of the component (different cases have different defocusing moments)
close #xxx
Pull Request Checklist