Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo files + split out .Common module #219

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dan-hughes
Copy link

@dan-hughes dan-hughes commented Jan 6, 2025

Pull Request (PR) description

Update the module files to the latest versions. Move functions from the HyperVDsc.Common module to separate Public/Private functions.

Fixed typo in one integration test that referenced old module name.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83%. Comparing base (6c0e583) to head (5f54f97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
source/Public/Set-VMProperty.ps1 72% 7 Missing ⚠️
source/Public/ConvertFrom-TimeSpan.ps1 80% 1 Missing ⚠️
source/Public/ConvertTo-TimeSpan.ps1 85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #219   +/-   ##
===================================
- Coverage    83%    83%   -1%     
===================================
  Files        11     17    +6     
  Lines      1441   1427   -14     
===================================
- Hits       1203   1189   -14     
  Misses      238    238           
Files with missing lines Coverage Δ
...ce/DSCResources/DSC_VMDvdDrive/DSC_VMDvdDrive.psm1 98% <ø> (-1%) ⬇️
...urces/DSC_VMHardDiskDrive/DSC_VMHardDiskDrive.psm1 89% <ø> (-1%) ⬇️
source/DSCResources/DSC_VMHost/DSC_VMHost.psm1 100% <ø> (ø)
source/DSCResources/DSC_VMHyperV/DSC_VMHyperV.psm1 84% <ø> (-1%) ⬇️
.../DSCResources/DSC_VMProcessor/DSC_VMProcessor.psm1 100% <ø> (ø)
...ces/DSC_VMScsiController/DSC_VMScsiController.psm1 100% <ø> (ø)
source/DSCResources/DSC_VMSwitch/DSC_VMSwitch.psm1 85% <ø> (-1%) ⬇️
source/Private/Wait-VMIPAddress.ps1 100% <100%> (ø)
source/Public/Get-VMHyperV.ps1 100% <100%> (ø)
source/Public/Set-VMState.ps1 100% <100%> (ø)
... and 4 more

@dan-hughes dan-hughes marked this pull request as ready for review January 6, 2025 15:16
@dan-hughes
Copy link
Author

@johlju

@dan-hughes dan-hughes changed the title Update repo files + remove .Common module Update repo files + split out .Common module Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant