Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for foreignObject and enhance label editing with multi-line support #171

Merged
merged 5 commits into from
Apr 3, 2020
Merged

Add support for foreignObject and enhance label editing with multi-line support #171

merged 5 commits into from
Apr 3, 2020

Conversation

planger
Copy link
Contributor

@planger planger commented Mar 24, 2020

@gitpod-io
Copy link

gitpod-io bot commented Mar 24, 2020 •
edited
Loading

@planger
Copy link
Contributor Author

planger commented Mar 24, 2020

Peek 2020-03-24 09-36

@planger planger requested a review from spoenemann March 24, 2020 08:48
@spoenemann spoenemann requested a review from tomvdbussche March 25, 2020 09:05
planger added 2 commits March 26, 2020 13:01
@planger
Make id and containerClass overridable
48ca10e 
Readonly properties aren't overridable by subclasses which limits
the customizability. If e.g. the id is not overridable, we cannot
register more than one UIExtension that inherits from the edit label UI.
@planger
Only remove child if it actually exists
5a0b08d
tomvdbussche
tomvdbussche requested changes Mar 28, 2020
View reviewed changes
src/lib/generic-views.tsx Outdated Show resolved Hide resolved
src/features/edit/edit-label-ui.ts Outdated Show resolved Hide resolved
@planger
Let labels overwrite static edit control dimension
70252d4 
By default, use a static dimension for edit labels, but let SModel elements
overwrite this static dimensions.
This change also fixes the key listeners (Esc to cancel editing) didn't
work anymore.
@planger
Copy link
Contributor Author

planger commented Mar 30, 2020

Thanks a lot @tomvdbussche for your review! I hope 70252d4 addresses your comments.

@planger planger requested a review from tomvdbussche March 30, 2020 08:30
@planger planger merged commit b8a6e44 into eclipse-sprotty:master Apr 3, 2020
@planger planger deleted the issues/169-foreignObject branch April 3, 2020 17:21
@spoenemann spoenemann added this to the v0.8.0 milestone Aug 19, 2020
@pcdavid pcdavid mentioned this pull request Oct 22, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomvdbussche tomvdbussche tomvdbussche approved these changes

@spoenemann spoenemann Awaiting requested review from spoenemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@planger @tomvdbussche @spoenemann